Jump to content


Photo

[fixed rc1] Deleting slice markers with looped slices, truncated loops


  • This topic is locked This topic is locked
2 replies to this topic

#1 Jenoki

Jenoki

    Local Chief Member

  • Normal Members
  • PipPipPipPipPip
  • 241 posts
  • Gender:Male
  • Location:England
  • Interests:cookies, cakes, cupcakes, muffins, ice creams, pepsi

Posted 15 December 2015 - 07:31

Hello!
 
Perhaps not a bug, but is a bit unexpected.
 
How to reproduce:
  • Insert a sample and set it to loop
  • Auto slice the sample
  • Delete 2nd slice marker
  • Play 1st slice
  • Notice that 1st slice will loop up to point of old slice marker
example webm
 
Expected outcome: Slice should automatically loop to the point of new slice marker

PbL0J.gif
-------------------------

CPU Intel i7 4770k 3.5ghz
OS Windows 10 Pro 64bit 1809
SSD 256GB OCZ Vertex 4
HDD 1TB Toshiba P300
RAM 16GB Kingston HyperX Beast
Audio Focusrite Saffire Pro 24
Video Gigabyte GTX 780 GHz Edition


#2 taktik

taktik

    Renoise Developer

  • Admins
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 15040 posts
  • Gender:Male
  • Location:Berlin, Germany
  • Interests:füße waschen

Posted 15 December 2015 - 15:00

Expected outcome: Slice should automatically loop to the point of new slice marker


Hello. That's exactly the question. Should it really? If you've customized the loop, you surely don't want that your hand-crafted loops get shifted/changed too when changing markers.

Could do it only "sometimes" then:
Only when the loop previously cover the entire sample - exactly.
Or only adjusting/expanding the loop end when it sits exactly at the end of the sample.

Also it's not only deleting. Moving an existing marker and adding new once, would need to adjust loops in some way then too.

So far we have, in doubt, simply not touched the loops when changing slice markers.
  • Jenoki likes this

#3 Jenoki

Jenoki

    Local Chief Member

  • Normal Members
  • PipPipPipPipPip
  • 241 posts
  • Gender:Male
  • Location:England
  • Interests:cookies, cakes, cupcakes, muffins, ice creams, pepsi

Posted 15 December 2015 - 21:14

If you've customized the loop, you surely don't want that your hand-crafted loops get shifted/changed too when changing markers.

 
Very good point!
 

Could do it only "sometimes" then:
Only when the loop previously cover the entire sample - exactly.
Or only adjusting/expanding the loop end when it sits exactly at the end of the sample.


Yup! These are good ideas, and how I actually expected to work :D
 

Moving an existing marker and adding new once, would need to adjust loops in some way then too.


If it's not too tricky to update slices with new loop markers, but only if entire slice is already looped, that would be great!

PbL0J.gif
-------------------------

CPU Intel i7 4770k 3.5ghz
OS Windows 10 Pro 64bit 1809
SSD 256GB OCZ Vertex 4
HDD 1TB Toshiba P300
RAM 16GB Kingston HyperX Beast
Audio Focusrite Saffire Pro 24
Video Gigabyte GTX 780 GHz Edition