Jump to content


Photo

BUG LUA automation writing undo history w/ autom follow


  • Please log in to reply
3 replies to this topic

#1 ffx

ffx

    Composes without Wires burns Directly from Brain to DVD that is already in Store Member

  • Normal Members
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 3378 posts
  • Gender:Not Telling

Posted 30 January 2018 - 14:51

If you write automation using LUA API, it will be split into multiple undo steps. Also undo / redo action will cause crashes / freezes.
 
 
 
Steps to reproduce:
 
1. Install ffx.tools.GUIAutomationRecorder V1.10
 
2. Enable "Automation Following" song option
 
3. Load a song with a VSTi. Play a pattern in loop and right click on an instrument which is playing and select "Record GUI controls"
 
4. Move one slider over the whole pattern.
 
5. End edit mode. Tool notifiers will be terminated then.
 
6. One time press undo. Strange changes in automation appear.
 
7. One time press redo. The result is not the same.
 
8. Multiple times undo / redo. Should freeze or crash Renoise
 
9. Repeat the whole thing this time disable "Automation Following" song option. Compare results. If the results are the same, repeat again.
 
 
Results:
 
With "Automation Following" enabled, the undo history will be fucked up, and the start values will be filled in randomly.
 
Without "Automation Following", the undo history will be correct. But still it will crash on undo/redo action.
 

 

EDIT: regarding the "Automation Following" + automation write problem: test it with the above tool, only with playing disabled. The problem will be obvious then with enabled "Automation Following". The just changed point with jump back to the sliders value. This also happens while playing, but then sometimes also not or much less...  :blink:

 

Some art, drawings beyond logic:
[attachment=7940:Bildschirmfoto 2018-01-30 um 14.53.20.PNG]
[attachment=7941:Bildschirmfoto 2018-01-30 um 15.24.35.PNG]
[attachment=7942:Bildschirmfoto 2018-01-30 um 15.27.12.PNG]
[attachment=7943:Bildschirmfoto 2018-01-30 um 15.24.43.PNG]
 
 
Crash log:

Spoiler

Edited by ffx, 31 January 2018 - 01:09.

Test system: macOS 10.13.4, HFS+. Firewire Audio, i7 4770, 8GB Ram, GTX1050 2GB, 48kHz
GUI Automation RecorderNative DSP Context MenuTuned ShortcutsUnified Value Shift And Transpose | Jump To From Send Modified (Docs) | Quick Template | Nisanmol's Groove Tool FixedThemes


#2 Raul (ulneiz)

Raul (ulneiz)

    Guruh Motha Fakka is Levitating and Knows Everything About Renoise Member

  • Normal Members
  • PipPipPipPipPipPipPipPipPipPipPipPipPip
  • 1442 posts
  • Gender:Male
  • Location:Spain

Posted 30 January 2018 - 16:36

Hi FFX

 

I'm trying to understand why this happens. Can you get a similar error without using tools? It is possible for the tool to do several operations in one step, and then to make and break go crazy.

 

But I understand that this should not happen. If a step is 8 hit operations, when undoing, you should undo the 8 operations. Renoise 3.1.1 has a problem with undo/redo related to the index of the tracks and the selection. I do not know if it also happens with the index of the sequence or the patterns. Maybe all this is related.

 

 

Undo and redo should return the exact previous or subsequent status, including any index, and that requires an exact previous registry. I think that in the subject of indexes and selection is not polished and it requires a deep revision. With the issue of points in automation, I do not know what it could be. Perhaps if the tool were written differently, these errors would be avoided.

 

It is not the first time that a tool closes Renoise. Many times it seems to be due to wanting to access something that does not exist, and that scenario is relatively simple to provoke with undo / redo.

 

I'm just thinking out loud. But I also say that I do not like to report errors and then be ignored for many months. There is no support!


:excl: Development of my tools: KangarooX120SamRenderPhraseTouch  |  GT16-Colors (old)

 

:excl: My API wishlist R3.1 (updated 24 July 2017):

Spoiler

 

:excl: My Renoise 3.1 wishlist (updated 26 September 2017):

Spoiler

#3 ffx

ffx

    Composes without Wires burns Directly from Brain to DVD that is already in Store Member

  • Normal Members
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 3378 posts
  • Gender:Not Telling

Posted 30 January 2018 - 16:52

I think this actually is multiple bugs in one:

 

- The corruption of automation data and drawing obviously is a (or two) bug inside Renoise

 

- Crash of Renoise. Seems to be the GUI of the target VST? It was MPS here, I assume it is quite solid and never crashes in different situations. Also I closed the GUI before! So maybe Renoise floods the plugin with way too much values on redo (while restoring a whole automation graph) or sends corrupted values (beyond 0...1) or similar

 

- Sometimes freeze of Renoise. Could be related to vst parameter feedback.

 

- "Automation Following" option is definitely buggy. It should be carefully overhauled and also being available in the API.

 

 

In any case - just as danoise stated in the other post - the API should never be able to crash Renoise.

 

 

 

With the issue of points in automation, I do not know what it could be. Perhaps if the tool were written differently, these errors would be avoided.

 
No, as I wrote, it happens while using UNDO/REDO, while the tool is offline, not having any notifiers active. The tool also writes the automation correctly as you can see. It has nothing to do with the way the tool is written.

Edited by ffx, 30 January 2018 - 17:01.

Test system: macOS 10.13.4, HFS+. Firewire Audio, i7 4770, 8GB Ram, GTX1050 2GB, 48kHz
GUI Automation RecorderNative DSP Context MenuTuned ShortcutsUnified Value Shift And Transpose | Jump To From Send Modified (Docs) | Quick Template | Nisanmol's Groove Tool FixedThemes


#4 ffx

ffx

    Composes without Wires burns Directly from Brain to DVD that is already in Store Member

  • Normal Members
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 3378 posts
  • Gender:Not Telling

Posted 30 January 2018 - 17:01

.


Edited by ffx, 30 January 2018 - 17:02.

Test system: macOS 10.13.4, HFS+. Firewire Audio, i7 4770, 8GB Ram, GTX1050 2GB, 48kHz
GUI Automation RecorderNative DSP Context MenuTuned ShortcutsUnified Value Shift And Transpose | Jump To From Send Modified (Docs) | Quick Template | Nisanmol's Groove Tool FixedThemes