I see, thanks for the report. Once I have a bit of time I’ll make a test tool with just a text window to see if it’s something about the tool or something specific to the fairly new Mac port of Renoise.
In the meantime if anyone else could tell me how this behaves on their setup it would be useful to narrow it down.
Just updated to the latest version…just wanted to say thanks again for the tool. I use it daily!
I’m affected this issue too (on mac) and believe i’ve found the source:
@unless if I comment out this line, leaving the command palette open, the newly opened text dialogue is focused.
What I think is happening, is the new text prompt is opened, then the old dialogue is closed - on mac, this makes the main window regain focus.
I’m working on a fix for this now and will probably open a PR against your repo if that’s cool with you!
OK, here’s the code for a working fix,
main.lua:
elseif msg.type == "finish" then
-- set callback to execute command after dialog is closed
o.callback = function(exit_code, m, o)
local command = m.list[m.selected]
-- print(m.initial)
local result = command.run(song, m.argument, m.initial)
if m.argument ~= nil then
command.finish(renoise.song(), m.argument, m)
table.insert(m.history, 1, command_call(command.alias, m.argument))
else
if command.type == "action" or command.type == "string" then
command.finish(renoise.song(), nil, m)
remember(command.alias, nil)
end
end
end
return CommandExitCode.SUCCESS
elseif msg.type == "crawl_history" then
The command execution logic has been moved into the handly callback you provided. This callback is invoked after the command palette is closed (I can’t remember how much of this i added, will consolidate into a PR when I have time)
lui.lua:
o.process = function(m, msg, o)
local exit_code = o.update(m, msg, o)
if exit_code == CommandExitCode.CONTINUE then
o.render(m)
else
if o.window.visible then
o.window:close()
end
if o.callback then
o.callback(exit_code, o.model, o)
end
PR is up here: -Fix an issue on mac where text prompts aren't initially focused by deferring... (!1) · Merge requests · unless games / unless_renoise · GitLab, I’ve applied the fix to the main palette and the paramater palette, I believe there are still some unfixed cases.
I’ve also expanded the “load plugin” feature to be able to select “none”, i.e unload the plugin. Unsure if it should be included in this PR
EDIT: This tool is making me enjoy renoise a whole not more, especially now I have a handle on the code. I’ve added a “new sample” command and my next goal is to add a palette similar to the DSP/fx parameter palette for sample properties and modulation sets.
Merging the fixes provided by @muximori to handle secondary popups not receiving focus on Mac.
While the fixes are simple and make complete sense from the code, unfortunately I don’t have access to a Mac to actually verify they work as intended (on Linux both the previous and post-fix versions work fine for me).
@neutron hopefully this will solve the problems you’ve reported previously!
Thanks again, your commits are merged now, I also added you in the readme and a GPL license file to make the legalities of code contributions clear for the future.
Unloading a plugin makes sense, haven’t thought about that, but maybe it should be a separate command?
Being able to set samples and their properties would be handy as well.
Feel free to send more pull requests.
This really is a great tool, it almost feels like a native feature. It’s a small detail, but I think the command and parameter lists would be a little easier to read if they were left-aligned.
uniform column-sizing similar to the mock-up provided by @detektiv_plok above
new command unload plugin to remove a loaded plugin from an instrument as proposed by @muximori
2 will loop the beat at your cursor and the next one, -3 will loop the previous 3 beats etc)Unfortunately the looping part of the API in Renoise behaves somewhat unexpectedly but these commands might still be useful.
None option on the plugin selection paletteThanks to @muximori for contributing some of these fixes and commands and inspiring me to add the rest.
Ctrl+EnterAlt+Up Alt+Down (Option on Mac) in addition to the existing DSP device switch