Script Undo Data Creation Skipped While Slider Mouse-Moved

Hi there,

think I’ve found a bug in the undo mechanism in 2.6 B6:

Steps to reproduce:

  • grab a slider of any DSP device / volume / pan inside Renoise with the mouse and hold mousebutton
  • while doing this change another parameter value of the same or another DSP device via script (via midi controller no undo events are created at all)
  • release the mouse button / the grabbed slider
  • undo the changes by pressing ctrl-z
  • Expected: only the parameter value of the grabbed slider should be undone
  • Bug: also the second parameter value is undone

BTW: the title of this post is a bit misleading but I can’t change it anymore.

Yes, thats related to the other “undo grouping” probs we have. Right now Renoise groups everything that happens between a mouse down,release or key press, release into one big group that is undone. The external change from the MIDI controller simply gets part of this group then. There right now is no way to create custom grouping for undo.

ok, good to know. Thanks for the info.
Guess it’s no the easiest topic, but are there any plans to rework that in a future release ?

Best regards

Yes, thats definitely something we should take care of. But I can’t promise that I’ll be able to change this for this release. Sorry…

ok, I can live with the workarounds right now. Better to make it solid than a hotfix-solution.
I’ll just continue sharing my scripting experiences in the forum. Hope this supports the redesign process :)

Hey Taktik,

was it possible to provide a function which indicates that “undo grouping” is active ?
I just needed a read-only flag. That would help me A LOT.

Right now I can’t detect value changes that are not added to undo stack
and that breaks my “counting undo workaround” everytime mouse/keyboard is pressed. Everything else works fine.

Here a little demo: in the first picture everything is moved without mouse/keyboard, volume is undone to 0 dB and different values and pan is undone to center and undone to different values. Everything works fine since no mouse/keyboard is pressed. In the second picture the mouse is pressed. And whoops my internal undo counter counts too much and thus the values of the other faders are affected, too. (had been moved in advance - not in video)