Jump to content


Photo

[BUG] Cloning Groups and collapse/Expand and others???

clone groups

  • Please log in to reply
5 replies to this topic

#1 Raul (ulneiz)

Raul (ulneiz)

    Guruh Motha Fakka is Levitating and Knows Everything About Renoise Member

  • Normal Members
  • PipPipPipPipPipPipPipPipPipPipPipPipPip
  • 1233 posts
  • Gender:Male
  • Location:Spain

Posted 05 October 2017 - 02:24

R3.1.1 x64, Windows 10

 

For my part, I checked the bugs where I was involved in the past:

 

 

 

>- Notes placed on the last line in each pattern, do not appear in Matrix Editor?
http://forum.renoise.com/index.php/topic/47974-notes-not-appear-in-matrix-editor-to-end-of-the-pattern-with-max-zoom/

 

This seems to work correctly. Tested even with 512 lines per pattern.

 

---

 

 

 

>- Tracks are swapped around when cloning a group:
http://forum.renoise.com/index.php/topic/48911-cloning-track-group-collapses-new-group-and-duplicates-twice/#entry353091

 

Group cloning now clones clues and child groups and its properties correctly, by dragging the parent group with CTRL. But for some reason, there is still something that does not work properly with "Collapse/Expand Group".  To verify this, create a parent group with several random child groups, and within those groups add multiple child tracks. Then collapse several groups randomly and clone the parent group. Final cloning does not return the same order of collapsed groups.

 

On the other hand, to clone a group, it is only possible by pressing CTRL and dragging with the mouse the desired group.

 

I think it is not possible to assign a keyboard command for "duplicate group", nor does an option appear in the group drop-down menu, something like Group/Duplicate, Group/Duplicate (incl. Patterns), same as the track menu.

 

After trying other things, I found this:

crash-clone-groups.png

Basically, I created a group with a child track. Then I've cloned the group. Finally I have dragged the cloned group into the first group, and the error appears. After this error, Renoise 3.1.1 automatically closes. This error has appeared after I have been manipulating groups and tracks, cloning, creating, deleting, collapsing/expanding the tracks and groups randomly. Maybe it's related. I do not think he has manipulated more than 40 tracks/groups.

 

Spoiler

:excl: Development of my tool: GT16-Colors

 

:excl: My API wishlist R3.1 (updated 24 July 2017):

Spoiler

 

:excl: My Renoise 3.1 wishlist (updated 26 September 2017):

Spoiler

#2 4Tey

4Tey

    Big Daddy Member

  • Normal Members
  • PipPipPipPipPipPipPip
  • 432 posts
  • Gender:Male

Posted 03 December 2017 - 18:07

Here is something to try Raul....

 

Load in Renoise (also preferably, clean Renoise, no tools enabled.)

Start up your Scripting Terminal editor and in the file TestPad.lua add say the following code:

function stobser()
  print("called!")
  renoise.song():delete_track_at(1)
end
renoise.song().selected_track_observable:add_notifier(stobser)

...and click execute, nothing really should happen, other than we have added a notifier on the selected_track movement and it will run that function accordingly.  Yes?  Now, I've also been kinda naughty and added a call to delete track index 1 in the notifier.  Producing a notifier feedback.

Keeping the scripting terminal editor open I can get Renoise to crash by just moving/clicking into another track with that installed here with Linux.  However YMMV, but I wouldn't like that running in the background if you are creating/cloning/moving/deleting tracks/groups.

 

Not saying it is related, but it is just a little food for thought with your above post Raul :)


Edited by 4Tey, 03 December 2017 - 18:10.

  • danoise likes this

#3 Ledger

Ledger

    Guruh Motha Fakka Knows More About Renoise Than Taktik

  • Normal Members
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 3518 posts
  • Gender:Male

Posted 03 December 2017 - 19:12

Insta-Crash on windows too!

 

Nice bug hunting again 4tey!


  • 4Tey likes this

--> Lua For Beginners <--
--> Lua for newbies <--

My Scripts On Forum

Top Tip!

 

cpu : Xeon 1231 v3, os : Win 7 64bit, audio: Audient iD4
posts as 4tune @ KvR and some other music related sites


#4 Raul (ulneiz)

Raul (ulneiz)

    Guruh Motha Fakka is Levitating and Knows Everything About Renoise Member

  • Normal Members
  • PipPipPipPipPipPipPipPipPipPipPipPipPip
  • 1233 posts
  • Gender:Male
  • Location:Spain

Posted 03 December 2017 - 20:29

@4Tey and Ledger

 

I think I told Ledger that the error that started this topic was made using a tool. But I was confused. This error made me after installing the newly released version 3.1.1 64 bit (Win10 64 bit). I did not even have any tools installed.

 

4Tey, you always do magic with these things. I hope it serve for something... I have tried your instructions and the same "GUI" error window appears.


  • Ledger and 4Tey like this

:excl: Development of my tool: GT16-Colors

 

:excl: My API wishlist R3.1 (updated 24 July 2017):

Spoiler

 

:excl: My Renoise 3.1 wishlist (updated 26 September 2017):

Spoiler

#5 4Tey

4Tey

    Big Daddy Member

  • Normal Members
  • PipPipPipPipPipPipPip
  • 432 posts
  • Gender:Male

Posted 03 December 2017 - 21:02

Thanks Ledger, Raul...saves me loading up Windows 95 :)

 

The only real thing I can quickly add Raul (as speculation) to this is that if you are guaranteed that no tools (i.e. no notifiers) were running when you are cloning/deleting/moving your tracks/groups around then that is more tricky to isolate, then these two things are probably not really related in this case.  Maybe you'll find what you were doing and be able to produce the steps to cause that crash later Raul (don't forget to check with no tools enabled to see if there is any 'naughty notifier' influence or not.)



#6 Raul (ulneiz)

Raul (ulneiz)

    Guruh Motha Fakka is Levitating and Knows Everything About Renoise Member

  • Normal Members
  • PipPipPipPipPipPipPipPipPipPipPipPipPip
  • 1233 posts
  • Gender:Male
  • Location:Spain

Posted 03 December 2017 - 21:45

Thanks Ledger, Raul...saves me loading up Windows 95 :)

 

The only real thing I can quickly add Raul (as speculation) to this is that if you are guaranteed that no tools (i.e. no notifiers) were running when you are cloning/deleting/moving your tracks/groups around then that is more tricky to isolate, then these two things are probably not really related in this case.  Maybe you'll find what you were doing and be able to produce the steps to cause that crash later Raul (don't forget to check with no tools enabled to see if there is any 'naughty notifier' influence or not.)

 

It is strange, since the test I did at the beginning was from Renoise, and it returned an error when dragging to clone a group, from the pattern editor, not from a tool. I do not remember the steps I did. I just started to duplicate tracks and groups, playing a little with the tracks, I did not even have any instruments added.

 

After reviewing all the thread again, I would not rule out having any tool installed in the background, doing nothing, with some active notifier. Specifically renoise.song().selected_track_observable or selected_track_index_observable. I'm not sure. But in this case it was adding tracks cloned from Renoise (pattern editor), not deleting. Maybe there is some error with a notifier.

 

However. I am regularly using a tool that uses these notifiers from selected_track or selected_track_index and recently Renoise has never returned an error of this type. So I'm a little lost here.

 

Strange things!

:excl: Development of my tool: GT16-Colors

 

:excl: My API wishlist R3.1 (updated 24 July 2017):

Spoiler

 

:excl: My Renoise 3.1 wishlist (updated 26 September 2017):

Spoiler





Also tagged with one or more of these keywords: clone groups