Disable Undo/Redo from Lua

Renoise Tool Development
1

Hi,

my send-to/from tool is a bit broken since renoise 3.1, because 3.1 now also undo buffers track color changes. The script uses a color flashing.

So I would like to request a feature that you can disable undo completely for all actions done by a script.

Is there currently a way to disable undo while color change?

Second request would be those two lua API functions:

Disable_Undo()

Enable_Undo()

So just before track color change and right after, I can place those two calls.

Please help.

2

Or is this a bug that was introduced in 3.1?

3

Taktik, please have a short look at this.

Install the tool: https://forum.renoise.com/t/new-tool-jump-to-from-send/34051

Bind the two keys. Now jump from a track to a send. The undo buffer is now flooded with all color fading colors.

What about a Api function " Disable_Undo_once ". , so only for the next operation, there will be no undo written? It’s also a problem in other tools, too.

4

Taktik, please have a short look at this.
What about a Api function " Disable_Undo_once ". , so only for the next operation, there will be no undo written?

Interesting idea. Having this as a one-time flag would avoid an otherwise major weakness.
I mean, the ability to disable undo entirely from Lua tools would be kind of ‘dangerous’, especially if a tool was somehow faulty…then undo would suddenly have been disabled for the remainder of your Renoise session, not good…

5

I mean, the ability to disable undo entirely from Lua tools would be kind of ‘dangerous’, especially if a tool was somehow faulty…then undo would suddenly have been disabled for the remainder of your Renoise session, not good…

Disabling undo will also quite easily break down the whole undo/redo logic and thus Renoise. If you for example suppress undo for the insertion of a track, but not for something else that you later on are doing with this track applying undo/redo will sooner or later crash.

So no, we can’t add that and have to solve this differently.

When the tool changes track colors, this always should have been in the undo/redo chains. Not sure why it wasn’t in 3.0.

6

Hey Taktik ,

And what about a undo “ID” , so in my case, I would set "set_undo_id_for_next_action(“crazy color flash”) " and for any next color change/exact same action in the tool, the previous undo with id “crazy color flash” in undo queue was deleted?

Would that in any warm harm stability?

7

Ok above makes no sense.

Can we revert old behavior then? Must be a color change really undoable, is this deluxe paint?

8

So, only “workaround” now is to completely go without crazy color fx?

Please, any help would be appreciated…!

EDIT: maybe it would be possible to put manual color changes to undo history, but not any color change made from LUA?