[Fixed 2.6.1] Crash With Bogus Pattern Insertion.

Renoise Tool Development
1

The attachment illustrates the statement that crashed renoise.

Just to clarify. Insertion at index 1 worked, at index 4 failed, and index 3 crashed renoise.

2

Hi,

A crash is when Renoise itself dies a horrible death.

You can find the crash logs under the menu: Help -> Show The Log File

Your screenshot shows only a Lua error, which is normal?

3

Hi,

I think the error in the screenshot is for passing 4 as the parameter.

I just reproduced this reliably on 2.6 final. It does appear to be a bug.

Steps to reproduce:

  • Open Renoise (my template song only has one pattern – this may affect it)
  • Open Scripting Terminal
  • renoise.song().sequencer:insert_new_pattern_at(1) - works
  • renoise.song().sequencer:insert_new_pattern_at(4) - caught in the lua terminal as an error
  • renoise.song().sequencer:insert_new_pattern_at(3) - Renoise crashes (unhandled exception in thread: GUI)
  • Renoises closes itself

Off by one error?

Hope this helps

4

Ok… I reread the message, I can reproduce the crash.

Steps to reproduce:

  1. Launch Renoise, Start a New Song
  2. Tools -> Scripting and Terminal Editor
  3. In the terminal type (press enter after each line):

$ renoise.song().sequencer:insert_new_pattern_at(1)
$ renoise.song().sequencer:insert_new_pattern_at(4)
$ renoise.song().sequencer:insert_new_pattern_at(3)

Crash:

  
ScriptingEngine: std::logic_error: 'invalid sequence_pos index '4'. valid values are (1-2).'  
stack traceback:  
 [C]: in function 'insert_new_pattern_at'  
 [string "renoise.song().sequencer:insert_new_pattern..."]:1: in main chunk  
  
  
CrashLog: 0 libSystem.B.dylib 0x95f2f46b _sigtramp + 43  
CrashLog: 1 ??? 0xffffffff 0x0 + 4294967295  
CrashLog: 2 Renoise 0x0011489e 0x0 + 1132702  
CrashLog: 3 Renoise 0x0011491f 0x0 + 1132831  
CrashLog: 4 Renoise 0x0016adce 0x0 + 1486286  
CrashLog: 5 Renoise 0x0029db3a 0x0 + 2743098  
CrashLog: 6 Renoise 0x002b8b37 0x0 + 2853687  
CrashLog: 7 Renoise 0x0029e9c8 0x0 + 2746824  
CrashLog: 8 Renoise 0x0028fae1 0x0 + 2685665  
CrashLog: 9 Renoise 0x0029ceb2 0x0 + 2739890  
CrashLog: 10 Renoise 0x0029d269 0x0 + 2740841  
CrashLog: 11 Renoise 0x00292772 0x0 + 2697074  
CrashLog: 12 Renoise 0x004fdb8e 0x0 + 5233550  
CrashLog: 13 Renoise 0x007b57bc 0x0 + 8083388  
CrashLog: 14 Renoise 0x007c1522 0x0 + 8131874  
CrashLog: 15 Renoise 0x007c1ec1 0x0 + 8134337  
CrashLog: 16 Renoise 0x0074f49b 0x0 + 7664795  
CrashLog: 17 Renoise 0x00754ed9 0x0 + 7687897  
CrashLog: 18 Renoise 0x006ffbe3 0x0 + 7338979  
CrashLog: 19 Renoise 0x00754cba 0x0 + 7687354  
CrashLog: 20 Renoise 0x0071f16a 0x0 + 7467370  
CrashLog: 21 Renoise 0x0071f324 0x0 + 7467812  
CrashLog: 22 Renoise 0x0075ad5b 0x0 + 7712091  
CrashLog: 23 Renoise 0x00620642 0x0 + 6424130  
CrashLog: 24 Renoise 0x007bf52d 0x0 + 8123693  
CrashLog: 25 Renoise 0x005ded12 0x0 + 6155538  
CrashLog: 26 Renoise 0x0060ec67 0x0 + 6351975  
CrashLog: 27 AppKit 0x96334a37 -[NSKeyBindingManager(NSKeyBindingManager_MultiClients) interpretEventAsCommand:forClient:] + 1911  
CrashLog: 28 AppKit 0x963382eb -[NSTextInputContext handleEvent:] + 1604  
CrashLog: 29 AppKit 0x963340a1 -[NSView interpretKeyEvents:] + 209  
CrashLog: 30 Renoise 0x00613513 0x0 + 6370579  
CrashLog: 31 Renoise 0x00613ae6 0x0 + 6372070  
CrashLog: 32 Renoise 0x005ffce7 0x0 + 6290663  
CrashLog: 33 Renoise 0x005ffbb0 0x0 + 6290352  
CrashLog: 34 Renoise 0x005cd1ce 0x0 + 6083022  
CrashLog: 35 Renoise 0x000be87f 0x0 + 780415  
CrashLog: 36 Renoise 0x004f62cf 0x0 + 5202639  
CrashLog: 37 Renoise 0x0001838a 0x0 + 99210  
CrashLog: 38 Renoise 0x000182b1 0x0 + 98993  
  
Application: Caught an unhandled exception (Thread: GUI)!  
Application: Saving a backup...

EDIT: Too slow, mxb wins.

5

Thanks for reporting. Will be fixed in the next Renoise update.