Sample Recorder does not toggle open/close using key binding assignment

This is only true for Renoise 3.5. The following did not occur on previous versions.

I have the “ Open Render Sample Recorder Dialog.. “ assigned to a key so as to quickly open and close the window. As of 3.5 it no longer toggles. It will open the Sample Recorder window but it will not toggle it open and close as it did in 3.4.4 ( and previous versions. ) This is a bit of a pain as it commands the focus of Renoise whereas in previous versions the focus remained on the last place that the focus was placed, for me that was the tracker window. So when I hit the space bar it will start to record a sample, in previous versions hitting the space bar would start the tracker. I can kind of get around it by clicking on the tracker window via the mouse which places the FOCUS back onto the tracker but this is a huge workflow change. In addition, one I open the Sample Recorder window my Tilde/left quote key no longer functions as a toggle for where the FOCUS is set on Renoise.

It would be greatly appreciated if this can be fixed.

Happy to create a lil video if that helps. Hopefully my explanation is clear enough to describe the problem,. Thank you in advance for your time and talents!

This was changed on purpose. See ESC cancels Sample Recorder recording or - if not recording, then closes the Sample Recorder - #7 by esaruoho

Open to discuss whether reverting to the old behavior would be less annoying. I’m not sure if the new behavior is really an improvement.

@taktik

it really seems like reverting to old behaviour would probably solve a lot of problems.

i mean, data loss with esc pressing wouldn’t be solved, but, considering that now one can’t run scripts while sample recorder is focused,.. i’d rather run scripts with sample recorder focused, than be scriptless.

Apologies for my first post, after reading esaruoho’ post I see that I could have done a better job and so here it is:

Steps to replicate:

  1. assign Open Sample Recorder Window to a keyboard button, any button. ( I use CLEAR on a full numerical Apple keyboard )
  2. Press the assigned keyboard button -
    Expected: Sample Recorder Window Open. Currently: sample recorder window opens
  3. Press the assigned keyboard button again - Expected: Sample Recorder Window closes Currently: Sample recorder window does not close

I am sure that this ties into ESC cancels Sample Record recording but it might not be the exact problem that I am describing here. That being said I am lacking sleep and not as sharp as I can be :grinning_face:

I think reverting to old behavior would be best.

Thanks!

I loathe the new behaviour ,
I’am all in in for bringing the old behaviour back

In Redux 1.4.2 the key binding I cannot even get it to open. Is this related?

(btw I prefer the toggle)