ESC cancels Sample Recorder recording or - if not recording, then closes the Sample Recorder

[esaruoho]

Steps to replicate:

1. Open Sample Recorder.
2. Press ESC
   Expected: Edit Mode is turned on, Sample Recorder stays open.
   Currently: Sample Recorder gets closed.

Steps to replicate:

1. Open Sample Recorder
2. Start recording.
3. Press ESC
   Expected: Edit Mode is turned on, Sample Recorder stays open and keeps recording
   Currently: Sample Recorder stops recording and cancels the recording = data loss.

please please please.

Thoughts On Sample Recorder

My issue with the sample recorder is that it takes Esc and Enter input and makes it a bad thing. Why not have the sample recorder not pay attention to Esc and Enter so that you can actually use those keys in the normal functions and not have them stop or totally end and scrap recording? For one, it conflicts with toggling record, and secondly, you can’t trigger sample playback in sample editor by hitting enter. But the main thing is that it causes crazy issues: losing partial recordings. Also, …

How to stop Sample Recorder Dialog from closing on Esc? ← 2018

Configurability so that ESC does not shut down Sample Recorder during recording(!)

i’ve lost so many recordings by pressing esc to toggle edit_mode = on → there it is, sample gone. any chance we could decide which shortcut closes the dialog?

API-solution? How to stop Esc from closing Sample Record Dialog?

Hi, I’m wondering, how could I absolutely, and once and for all, stop Esc from closing the Sample Record Dialog? Do I need to have some sort of GUI window open that relays Esc only to the pattern editor or…?

How to detect if Sample Recorder is recording?

Hi, is there some way of detecting if the Sample Recorder is recording or not? I use Esc for edit mode on/off, but Esc also cancels (!) and hides the sample recorder. How would I go about detecting that if the Sample Recorder is recording, then either stop recording, or at least don’t hide the sample recorder dialog. EDIT: what i’m seeing is / are: -- Dialog for recording new samples, floating above the main window. renoise.app().window.sample_record_dialog_is_visible -> [boolean] -- Sta…

[taktik]

I’m actually not sure why we did this (a long time ago), but the sample recorder is the only dialog which grabs escape (to close) and return keys (to start/stop record), even when not focused.

I can see that escape can be annoying here. I’ll remove both for the next update…

[esaruoho]

wow! thank you so much!!!

[esaruoho]

@taktik
unfortunately, i’m told that the fix now means that you cannot, after opening the sample recorder, run any shortcuts (such as shortcuts to tools for stopping the recording, because the sample recorder now eats all focus.

[taktik]

Yes. The dialog should either handle all keys or no keys at all. Everything else is just confusing UX wise.

[esaruoho]

i mean, the “don’t have ESC stop recording in order to evade data loss” fix was great…

but the rest (as in) “eat all keypresses and never pass them out to renoise app out of Sample Recorder dialog, with no way to set up a keyhandler for it” went slightly overboard.

Maybe there’s a way to evade it with scripting, but when not using scripting, this results in requiring an additional mouse click to drop Sample Recorder focus.

[esaruoho]

is there no way it could pass keybindings to the main app?

now when sample recorder is open, one needs to defocus away from the sample recorder (not possible with the API) with a click - and thus any script that is built to use the sample recorder is now unusable.

and now people who are definitely focused on the sample recorder, cannot use the return key to start and stop recording.

Sample recorder behaviour in 3.5

I’ve become very accustomed to recording samples quickly in pattern mode by pressing: SHIFT+ALT+R (opens sample recorder) ENTER (arms recording on play) SPACE BAR (starts recording) Step 3 doesn’t seem to work for me anymore without clicking outside the sample recorder window first. Did it change in the new version or it’s something in my settings? I really enjoyed not having to reach for the mouse every time.